Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted #10046

Closed
wants to merge 0 commits into from
Closed

Deleted #10046

wants to merge 0 commits into from

Conversation

NazimHAli
Copy link
Contributor

I initially started working on a different project to build a forum using Firestore as the backend + Firebase auth as the authentication. After reading this post https://community.nodebb.org/topic/15941/google-firestore-dbal/6 and discovering this example PR to add a database adapter, I think we can add Firestore support too.

This is a work in progress, suggestions/contributions welcome. I'm new to this codebase and still don't fully understand the adapter requirements, just going off of the PR mentioned above and other 2 DB source codes. Any help is appreciated!

@pitaj
Copy link
Contributor

pitaj commented Dec 1, 2021

Please rebase on master so your PR doesn't include irrelevant changes and commits.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2021

CLA assistant check)
All committers have signed the CLA.

@NazimHAli NazimHAli closed this Dec 2, 2021
@NazimHAli NazimHAli deleted the enh-firestore-adapter branch December 2, 2021 00:15
@NazimHAli
Copy link
Contributor Author

Please rebase on master so your PR doesn't include irrelevant changes and commits.

@pitaj something went wrong with rebasing and I've been using the stable branch, going to switch to master for dev and create a new branch.

@NazimHAli NazimHAli changed the title ENH: Add Firestore adapter Deleted Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants