Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jimp with sharp #6774

Merged
merged 8 commits into from Sep 20, 2018
Merged

Replace jimp with sharp #6774

merged 8 commits into from Sep 20, 2018

Conversation

@barisusakli
Copy link
Member

@barisusakli barisusakli commented Sep 18, 2018

@barisusakli barisusakli added this to the 1.10.2 milestone Sep 18, 2018
@barisusakli barisusakli self-assigned this Sep 18, 2018
@julianlam
Copy link
Member

@julianlam julianlam commented Sep 18, 2018

WIP? need review?

@barisusakli
Copy link
Member Author

@barisusakli barisusakli commented Sep 18, 2018

Almost, I want to bring back the old way of resizing with just a single path, instead of suplying target on all calls.

barisusakli added 3 commits Sep 18, 2018
@barisusakli barisusakli requested a review from julianlam Sep 18, 2018
@julianlam julianlam changed the title 6747 Replace jimp with sharp Sep 20, 2018
Copy link
Member

@julianlam julianlam left a comment

💯

@barisusakli barisusakli merged commit b7ead6d into master Sep 20, 2018
4 of 5 checks passed
4 of 5 checks passed
codeclimate 2 issues to fix
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 89.192%
Details
license/cla All CLA requirements met.
@barisusakli barisusakli deleted the 6747 branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants