Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category watch state #7109

Merged
merged 19 commits into from Dec 14, 2018

Conversation

@barisusakli
Copy link
Member

commented Dec 14, 2018

Add a new not-watching state to categories.
Add ACP setting to set the default watch state for all users
Add UCP setting to override the ACP setting

Remove cid:<cid>:ignorers, replaced by cid:<cid>:uid:watch:state. The score is the user's watch state (1-ignoring, 2-notwatching, 3-watching)

Upgrade script to set ignoring state if user was in cid:<cid>:ignorers

@barisusakli barisusakli self-assigned this Dec 14, 2018

@barisusakli barisusakli requested review from psychobunny and julianlam Dec 14, 2018

@barisusakli barisusakli referenced this pull request Dec 14, 2018

Merged

Category watch state #445

barisusakli added some commits Dec 14, 2018

};

Categories.getIgnorers = function (cid, start, stop, callback) {
let count = stop - start + 1;

This comment has been minimized.

Copy link
@pitaj

pitaj Dec 14, 2018

Contributor
const count = (stop === -1) ? -1 : (stop - start + 1);

This comment has been minimized.

Copy link
@barisusakli

barisusakli Dec 14, 2018

Author Member

👍

@barisusakli barisusakli added this to the 1.12.0 milestone Dec 14, 2018

@barisusakli barisusakli merged commit eb7ae54 into master Dec 14, 2018

4 of 5 checks passed

codeclimate 6 issues to fix
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 89.671%
Details
license/cla All CLA requirements met.

barisusakli added a commit to NodeBB/nodebb-theme-vanilla that referenced this pull request Dec 14, 2018

barisusakli added a commit to pichalite/nodebb-theme-slick that referenced this pull request Dec 14, 2018

@julianlam julianlam modified the milestones: 1.12.0, 1.11.2 Jan 24, 2019

@barisusakli barisusakli deleted the category-watch-state branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.