Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "See all chats" link to mobile chat slideout #424

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@trjohnst
Copy link
Contributor

trjohnst commented Aug 14, 2018

Overview

The chats dropdown and chat slideout only display the 10 most recent chats. For desktop viewing, there is a "See all chats" button that solves the issue of seeing all of a users chat by navigating to the chats page. On mobile, there is no such button. This forces users to manually type in the url to get to the chats page in order to see more than the 10 most recent chats.

This PR adds a link to the chats page in the mobile chats slide out drawer.

Testing

Used against two local versions of NodeBB installed, one at 1.7.5 and the other at 1.9.3, both used for testing a previous migration script that I wrote. I don't have an in depth knowledge of what changes between versions but the variables used could be confirmed that they were not removed in later versions of NodeBB:

  1. relative_path: okay, used in the same file
  2. user.userslug: okay, used in other files
  3. [[modules:chat.see_all]]: okay, used in templates/partials/menu.tpl

Preview

nodebb-see-all-chats-mobile

@julianlam

This comment has been minimized.

Copy link
Member

julianlam commented Aug 23, 2018

@julianlam julianlam closed this Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.