Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QEMU #214

Closed
wants to merge 3 commits into from
Closed

Remove QEMU #214

wants to merge 3 commits into from

Conversation

@lite20
Copy link
Contributor

@lite20 lite20 commented Feb 28, 2016

This removes QEMU from the NodeOS build process. Please review the changes.

@piranna piranna added the in progress label Feb 28, 2016
@lite20
Copy link
Contributor Author

@lite20 lite20 commented Feb 28, 2016

If you can, please run the build process and see that all is clear. If it is, you may merge it, or let me know and I'll merge it (has to be done manually) I'm off to bed! Thank you!

@lite20 lite20 assigned lite20 and piranna and unassigned lite20 Feb 28, 2016
@piranna
Copy link
Member

@piranna piranna commented Feb 28, 2016

Could you be able to remove the blank line removals? Beside that I don't think there's too much more for it (only the location path of the QEmu executable used by the test and start scripts), and the patch can be used as guideline to create the npm package :-)

@lite20
Copy link
Contributor Author

@lite20 lite20 commented Feb 28, 2016

Yeah sure I'll get to work on that

@piranna
Copy link
Member

@piranna piranna commented Feb 28, 2016

👍

@lite20
Copy link
Contributor Author

@lite20 lite20 commented Mar 1, 2016

Alright. All is fixed. May I merge?

@piranna
Copy link
Member

@piranna piranna commented Mar 1, 2016

Now it's good, thank you ;-) I have some pending changes that I would like to merge previously to this one. While I'm working on them, could you be able to pick you changes and create a new project and npm qemu module with them? You can get them from https://github.com/NodeOS/NodeOS/pull/214/files. On a first step is not necesary to use prebuild and it's ok just download and compile it as it's currently done (only that on an independent dependency, not as part of NodeOS build process), we can add support for it later :-)

@piranna
Copy link
Member

@piranna piranna commented Mar 1, 2016

Please remove too the JOBS constant and the targetList array, since they are only being used to compile QEmu and now that's removed they are useless (obviously you'll need them when you'll create the qemu module... :-D ).

@piranna
Copy link
Member

@piranna piranna commented Mar 1, 2016

And the child_process and the os requires, too :-P

@piranna piranna mentioned this pull request Mar 3, 2016
@lite20
Copy link
Contributor Author

@lite20 lite20 commented Mar 16, 2016

Okay so I ought to finish this now that I have some free time. Would be easier to restart since your commits broke compatibility with this patch, so I'll go reset real quick.

@piranna
Copy link
Member

@piranna piranna commented Mar 16, 2016

You could be able to do a rebase and don't lose your current commits...
El 16/3/2016 5:15, "Lite McFish" notifications@github.com escribió:

Okay so I ought to finish this now that I have some free time. Would be
easier to restart since your commits broke compatibility with this patch,
so I'll go reset real quick.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#214 (comment)

@piranna piranna closed this Apr 4, 2016
@piranna piranna removed the in progress label Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.