This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you can, please run the build process and see that all is clear. If it is, you may merge it, or let me know and I'll merge it (has to be done manually) I'm off to bed! Thank you!
Could you be able to remove the blank line removals? Beside that I don't think there's too much more for it (only the location path of the QEmu executable used by the test and start scripts), and the patch can be used as guideline to create the npm package :-)
Now it's good, thank you ;-) I have some pending changes that I would like to merge previously to this one. While I'm working on them, could you be able to pick you changes and create a new project and npm qemu module with them? You can get them from https://github.com/NodeOS/NodeOS/pull/214/files. On a first step is not necesary to use prebuild and it's ok just download and compile it as it's currently done (only that on an independent dependency, not as part of NodeOS build process), we can add support for it later :-)
Please remove too the JOBS constant and the targetList array, since they are only being used to compile QEmu and now that's removed they are useless (obviously you'll need them when you'll create the qemu module... :-D ).
Okay so I ought to finish this now that I have some free time. Would be easier to restart since your commits broke compatibility with this patch, so I'll go reset real quick.
You could be able to do a rebase and don't lose your current commits...
El 16/3/2016 5:15, "Lite McFish" notifications@github.com escribió:
Okay so I ought to finish this now that I have some free time. Would be
easier to restart since your commits broke compatibility with this patch,
so I'll go reset real quick.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub #214 (comment)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
This removes QEMU from the NodeOS build process. Please review the changes.