Add support for VS 2019 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds default support for building with Visual Studio 2019. Note that %VCToolsInstallDir%, referenced in the generated binding.gyp files, is only set by default in the "Developer Command Prompt for VS 2019."
|
Possible this helps with #137? |
gvmani
reviewed
May 15, 2020
| @@ -51,7 +51,9 @@ | |||
| "VCCLCompilerTool": { | |||
| "AdditionalUsingDirectories": [ | |||
| "%ProgramFiles(x86)%/Microsoft Visual Studio 14.0/VC/lib/store/references", | |||
| "%ProgramFiles%/Microsoft Visual Studio 14.0/VC/lib/store/references" | |||
| "%ProgramFiles%/Microsoft Visual Studio 14.0/VC/lib/store/references", | |||
| "%ProgramFiles(x86)%/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/lib/x86/store/references", | |||
There was a problem hiding this comment.
Isn't this path specific to VS Community version ? Enterprise and Professional version will have different path.
lxbndr
reviewed
Jun 11, 2020
| "%ProgramFiles%/Microsoft Visual Studio 14.0/VC/lib/store/references" | ||
| "%ProgramFiles%/Microsoft Visual Studio 14.0/VC/lib/store/references", | ||
| "%ProgramFiles(x86)%/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/lib/x86/store/references", | ||
| "%VCToolsInstallDir%/lib/x86/store/references" |
There was a problem hiding this comment.
Suggested change
| "%VCToolsInstallDir%/lib/x86/store/references" | |
| "$(VCToolsInstallDir)lib/x86/store/references" |
I guess this will make build system resolve path, instead of depending on preconfigured environment.
MaySoMusician
added a commit
to MaySoMusician/NodeRT
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default support for building with Visual Studio 2019. Note that %VCToolsInstallDir%, referenced in the generated binding.gyp files, is only set by default in the "Developer Command Prompt for VS 2019."