Permalink
Browse files

readme: please include bench results on iffy pull requests

  • Loading branch information...
1 parent f120cbd commit 49c73bac304c89044e539bffae2a256627e8d0c6 @DTrejo DTrejo committed Jul 13, 2012
Showing with 10 additions and 0 deletions.
  1. +10 −0 README.md
View
@@ -592,6 +592,16 @@ I think there are more performance improvements left in there for smaller values
- your code should be the same style as the rest of the code
- add your tests to `./test.js`
- add your documentation to `README.md` (if needed).
+- if you think your change will make node_redis slower, run this:
+
+ git checkout master
+ node multi_bench.js > before.txt
+ git checkout branch-with-your-change
+ node multi_bench.js > after.txt
+ ./diff_multi_bench_output.js before.txt after.txt
+
+ and please attach a screenshot of the output (if it's not faster I recommend
+ trying to make it faster!).
- open a pull request!
## Contributors

0 comments on commit 49c73ba

Please sign in to comment.