Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use colon ( : ) as separator when joining keys. #386

Closed
chakrit opened this Issue · 1 comment

1 participant

@chakrit

I believe : is the convention the redis community uses to namespace keys.

From my experiments, this module supports passing in an array as keys which will automatically be joined... but with a comma instead ,

Why is this? Is it because keys were joined with .join without specifying the character?

Has there been a discussion or an issue raised as to why , was picked? accidental or not?

And is there any chance of this being changed? (fixed?) Maybe in a 0.9.0, so as not to break existing users? Or maybe make it configurable via the createClient options hash?

Reference: http://stackoverflow.com/questions/6965451/redis-key-naming-conventions

@chakrit

Ah, this seems to be a byproduct of toString()-ing an array.

Saw this used in https://github.com/tblobaum/redis-graph/blob/master/index.js#L153

I guess I should turns this into a feature request :/

@chakrit chakrit closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.