Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp to debug traces #1426

Merged
merged 4 commits into from May 7, 2019

Conversation

@ethervoid
Copy link
Contributor

ethervoid commented Apr 3, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? No need for docs here

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Trying to follow connection spikes with debug traces was a bit cumbersome so I've added timestamp to them so it becomes easier to follow the events through the time.

You can see a sample of the logs here:

2019-04-03T15:35:45.224Z Stream connected localhost:6379 id 0
2019-04-03T15:35:45.226Z Checking server ready state...
2019-04-03T15:35:45.227Z Send localhost:6379 id 0: *1\r\n$4\r\ninfo\r\n
2019-04-03T15:35:45.229Z Net read localhost:6379 id 0
2019-04-03T15:35:45.231Z Redis server ready.
2019-04-03T15:35:45.231Z on_ready called localhost:6379 id 0'
@ethervoid ethervoid force-pushed the ethervoid:add_timestamp_to_debug branch from b6bf94a to d913f4b Apr 3, 2019
ethervoid added 3 commits Apr 3, 2019
@BridgeAR BridgeAR merged commit f384e86 into NodeRedis:master May 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented May 7, 2019

@ethervoid thanks a lot for your contribution!

@ethervoid ethervoid deleted the ethervoid:add_timestamp_to_debug branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.