Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Parser Fix Bundle #382

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Owner

brycebaril commented Feb 24, 2013

Includes three key fixes for the built-in parser:

  1. Correctly bubbles non-parser exceptions back to the caller.
  2. Fixes an offset error on WATCH/MULTI/EXEC aborted transactions.
  3. Fixes a command queue error when a TCP packet break is in the middle of a nested MULTIBULK reply, which causes a cascade of errors.

This replaces PR #361 and fixes #377 #289 #373 #364 #325 and probably #316

Contributor

DTrejo commented Mar 10, 2013

Taken! Thanks for your patience w/r/t me taking forever to review. Since you're a committer now, I think it will probably be enough in the future for me to read through the diff and then +1 or +1 with criticisms, rather than put it through the whole quality check that I do for most PRs.

92ed0be

√ tests pass
√ no perf regression, at least didn't look like it
√ tests dont pass without your code
D

@DTrejo DTrejo closed this Mar 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment