Enable client command #401

Merged
merged 2 commits into from Mar 15, 2013

Conversation

Projects
None yet
2 participants
@dohse
Contributor

dohse commented Mar 14, 2013

The multi word commands starting with client (in lowercase) currently collide with multi's internal variable client. Rename the later to enable this command.
#363 introduced the ability to execute multi word commands.

dohse referenced this pull request in dohse/node_redis Mar 14, 2013

test.js
+ }
+
+ function checkResult(result) {
+ var lines = result.toString().split('\n').slice(0, -1);

This comment has been minimized.

Show comment Hide comment
@brycebaril

brycebaril Mar 14, 2013

Owner

4-space indentation vs. 2

@brycebaril

brycebaril Mar 14, 2013

Owner

4-space indentation vs. 2

index.js
@@ -663,15 +663,15 @@ RedisClient.prototype.send_command = function (command, args, callback) {
if (Array.isArray(args)) {
if (typeof callback === "function") {
// probably the fastest way:
- // client.command([arg1, arg2], cb); (straight passthrough)
+ // _client.command([arg1, arg2], cb); (straight passthrough)

This comment has been minimized.

Show comment Hide comment
@brycebaril

brycebaril Mar 14, 2013

Owner

It looks like perhaps your search-and-replace changed too many lines? These comments are about something else.

@brycebaril

brycebaril Mar 14, 2013

Owner

It looks like perhaps your search-and-replace changed too many lines? These comments are about something else.

index.js
// send_command(command, [arg1, arg2], cb);
} else if (! callback) {
// most people find this variable argument length form more convenient, but it uses arguments, which is slower
- // client.command(arg1, arg2, cb); (wraps up arguments into an array)
+ // _client.command(arg1, arg2, cb); (wraps up arguments into an array)

This comment has been minimized.

Show comment Hide comment
@brycebaril

brycebaril Mar 14, 2013

Owner

Same as above (and more below)

@brycebaril

brycebaril Mar 14, 2013

Owner

Same as above (and more below)

@dohse

This comment has been minimized.

Show comment Hide comment
@dohse

dohse Mar 15, 2013

Contributor

I fixed the white space and comment edits

Contributor

dohse commented Mar 15, 2013

I fixed the white space and comment edits

brycebaril added a commit that referenced this pull request Mar 15, 2013

@brycebaril brycebaril merged commit a5dc989 into NodeRedis:master Mar 15, 2013

@brycebaril

This comment has been minimized.

Show comment Hide comment
@brycebaril

brycebaril Mar 15, 2013

Owner

Looks great, thanks, @dohse 👍

Owner

brycebaril commented Mar 15, 2013

Looks great, thanks, @dohse 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment