Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Bug: xread in cluster mode calculates slots on wrong arguments #32

Closed

Conversation

Projects
None yet
3 participants
@voraparth91
Copy link

commented May 8, 2019

Example command: XREAD COUNT 2 STREAMS mystream writers 0-0 0-0

In this case, it should calculate slot on mystream and writers while it calculates on 'COUNT'. This is a bug in case of cluster mode.

Solution: now xread is considered a special case where we find all the streams name that are after keyword: STREAMS till ID starts.

@BridgeAR
Copy link
Member

left a comment

The code itself is LGTM. Please have a look at the linter errors though and write the code in the code style as the rest of the file. Thanks!

@borsucok

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

I think this is solved here: #31

@BridgeAR

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@voraparth91 thanks a lot for your contribution! This has been superseded by #31.

@BridgeAR BridgeAR closed this May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.