refactor(js-x-ray): remove is-minified-code from dependencies and re-implement it in utils #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b1d402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the external dependency is-minified-code and re-implements the minified code detection logic internally as a utility function. This reduces external dependencies and brings the implementation in-house.
- Adds new
isMinifiedCode.tsutility implementing minified code detection - Removes
is-minified-codefrom package dependencies - Updates imports to use the internal implementation instead of the external package
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspaces/js-x-ray/src/utils/isMinifiedCode.ts | New internal implementation of minified code detection logic |
| workspaces/js-x-ray/src/utils/index.ts | Exports the new isMinifiedCode function |
| workspaces/js-x-ray/src/AstAnalyser.ts | Updates imports to use internal implementation instead of external package |
| workspaces/js-x-ray/package.json | Removes is-minified-code dependency |
| .changeset/two-points-share.md | Documents the change in the changeset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…implement it in utils
fraxken
force-pushed
the
is-minified-code
branch
from
125e699 to
2b1d402
Compare
PierreDemailly
approved these changes
Nov 8, 2025
clemgbld
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.