Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/utils/analyzeDependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function analyzeDependencies(dependencies, deps = {}) {
const thirdPartyDependencies = dependencies
.map((name) => (packageDeps.includes(name) ? name : getPackageName(name)))
.filter((name) => !name.startsWith("."))
.filter((name) => !kNodeModules.has(name))
.filter((name) => !isNodeCoreModule(name))
.filter((name) => !packageDevDeps.includes(name))
.filter((name) => !tryDependencies.has(name));

Expand All @@ -24,7 +24,7 @@ export function analyzeDependencies(dependencies, deps = {}) {
thirdPartyDependencies
);
const missingDependencies = [...new Set(difference(thirdPartyDependencies, packageDeps))];
const nodeDependencies = dependencies.filter((name) => kNodeModules.has(name));
const nodeDependencies = dependencies.filter((name) => isNodeCoreModule(name));

return {
nodeDependencies,
Expand All @@ -38,3 +38,14 @@ export function analyzeDependencies(dependencies, deps = {}) {
}
};
}

/**
* @param {!string} moduleName
* @returns {boolean}
*/
function isNodeCoreModule(moduleName) {
const cleanModuleName = moduleName.startsWith("node:") ? moduleName.slice(5) : moduleName;

// Note: We need to also check moduleName because builtins package only return true for 'node:test'.
return kNodeModules.has(cleanModuleName) || kNodeModules.has(moduleName);
}
21 changes: 21 additions & 0 deletions test/utils/analyzeDependencies.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,27 @@ test("analyzeDependencies should detect Node.js dependencies and also flag hasEx
tape.end();
});

test("analyzeDependencies should detect prefixed (namespaced 'node:') core dependencies", (tape) => {
const packageDeps = ["node:foobar"];
const packageDevDeps = [];

const result = analyzeDependencies([
"node:fs",
"node:test",
"node:foobar"
], { packageDeps, packageDevDeps, tryDependencies: new Set() });

tape.deepEqual(result, {
nodeDependencies: ["node:fs", "node:test"],
thirdPartyDependencies: ["node:foobar"],
unusedDependencies: [],
missingDependencies: [],
flags: { hasExternalCapacity: false, hasMissingOrUnusedDependency: false }
});

tape.end();
});

test("analyzeDependencies should be capable of detecting unused dependency 'koa'", (tape) => {
const packageDeps = ["koa", "kleur"];
const packageDevDeps = ["mocha"];
Expand Down