From cb9a1886e39af58d6e291fbdae0065af65093499 Mon Sep 17 00:00:00 2001 From: SofianD Date: Fri, 1 Jul 2022 20:17:55 +0200 Subject: [PATCH 1/2] refactor(isGitDependency.js): use regex to check version --- src/utils/isGitDependency.js | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/utils/isGitDependency.js b/src/utils/isGitDependency.js index 1b0300ca..b7174b4a 100644 --- a/src/utils/isGitDependency.js +++ b/src/utils/isGitDependency.js @@ -1,5 +1,3 @@ -const kGitVersionVariants = ["git:", "git+", "github:"]; - /** * @example isGitDependency("github:NodeSecure/scanner") // => true * @example isGitDependency("git+ssh://git@github.com:npm/cli#semver:^5.0") // => true @@ -9,12 +7,5 @@ const kGitVersionVariants = ["git:", "git+", "github:"]; * @returns {boolean} */ export function isGitDependency(version) { - for (const variant of kGitVersionVariants) { - if (version.startsWith(variant)) { - return true; - } - } - - return false; + return /^git(\:|\+|hub:)/.test(version); } - From 3f45b12d594c4b589333a89cedb110a775c40028 Mon Sep 17 00:00:00 2001 From: SofianD Date: Fri, 1 Jul 2022 20:18:51 +0200 Subject: [PATCH 2/2] feat(depWalker.js): deepReadEdges check if its a git dep --- src/depWalker.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/depWalker.js b/src/depWalker.js index c0629147..0e415653 100644 --- a/src/depWalker.js +++ b/src/depWalker.js @@ -93,6 +93,10 @@ export async function* deepReadEdges(currentPackageName, options) { current.addFlag("hasValidIntegrity", _integrity === integrity); current.addFlag("isDeprecated"); current.addFlag("hasCustomResolver", customResolvers.size > 0); + + if (isGitDependency(to.resolved)) { + current.isGit(to.resolved); + } } current.addFlag("hasDependencies", to.edgesOut.size > 0);