Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed the signing process for extension Page Eraser #49

Open
p0rtia opened this issue Nov 8, 2016 · 19 comments
Open

failed the signing process for extension Page Eraser #49

p0rtia opened this issue Nov 8, 2016 · 19 comments

Comments

@p0rtia
Copy link

@p0rtia p0rtia commented Nov 8, 2016

can you check it?
After "Sign and Install" i get the error: "Signing failed. Not logged in AMO" but I'm already logged in into AMO-Account.
https://chrome.google.com/webstore/detail/page-eraser/ekofpchjmoalonajopdeegdappocgcmj

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

Are you in private mode?

@p0rtia
Copy link
Author

@p0rtia p0rtia commented Nov 8, 2016

No. vpn, adblk+, blur, noscript

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

That's interesting. This bug I have seen only when in private mode. When you got addons.mozilla.org do you see yourself loged in like this:

@p0rtia
Copy link
Author

@p0rtia p0rtia commented Nov 8, 2016

Thats right. But there is funny thing - when I click "Signing failed. Not logged in AMO. Open Login in New Tab" i have this:
firefox1
when I click CONTINUE, it redirects to login page, and again like above: click CONTINUE and I'm stuck i the loop
LOL

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

Oh shoot haha, thanks for sharing that screenshot, I'll try to reproduce this and get back to you as soon as possible. :)

@p0rtia
Copy link
Author

@p0rtia p0rtia commented Nov 8, 2016

ok. I've just killed my local firefox profile and started from scratch. And there is a progress ;)
Signing failed, max attempts reached while waiting for review to complete. The review may have failed.Open Validation Report in New Tab
And report looks like that:
firefox2
looks like problem with addon?

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

Ah yes those are issues previously brought up with the Mozilla team via bugzilla (links should be somewhere in Foxified Issues). They said they wont support anything but spanning for incognito. And the jquery old versions are banned. :(

@tenminute
Copy link

@tenminute tenminute commented Nov 8, 2016

I tried this as well the other day but had the same exact issues as p0rtia. Yes, I saw myself logged in and was stuck in that loop. I'm on version 49 and tried Google Translate. I did get it to temporarily install though.

https://play.google.com/store/apps/details?id=com.google.android.apps.translate&hl=en

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

Thank for sharing @tenminute - were you in a private window? Or in a private session? Or is your history set to "Never remember" as in screenshot below:

@tenminute
Copy link

@tenminute tenminute commented Nov 8, 2016

No private browsing. But yeah... my history is set to "Never remember".

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

May you please try turning it off then seeing if it works.

@tenminute
Copy link

@tenminute tenminute commented Nov 8, 2016

Sweet... got it to work. Thanks...

After it signed, I clicked for it to install but then I got an error saying it couldn't install because it was corrupt. I closed the error and clicked install again and it worked (I don't know why that error happened).

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Nov 8, 2016

It must be that the manifest.json is using stuff not yet supported by WebExtensions. Google Chrome manifest.json has a lot more. When you got it to install the 2nd time, does the addon actually work?

@tenminute
Copy link

@tenminute tenminute commented Nov 8, 2016

Seems to be. I messed around with it a little to see if it does what I need it to do.

@Ordval
Copy link

@Ordval Ordval commented Feb 21, 2017

May you please try turning it off then seeing if it works. (Noitidart)

What exactly is it that we need to turn off... (because my 51.0.1 (32 bits) is set to “Remember history”)
...and does the Browser need to be restarted ? I'm logged in to addons.mozilla.org. Cookies are allowed.
With “Never remember history” set it's not possible to even begin an install of a Chrome Add-On.
I'm at Windows 10, trying to install “FreeMyBrowser” or two others of the same kind .

@Noitidart
Copy link
Owner

@Noitidart Noitidart commented Feb 21, 2017

@Ordval by turn off I meant to switch to "Remember history" to allow cookies etc. But you are still seeing the same issue?

@Ordval
Copy link

@Ordval Ordval commented Feb 21, 2017

Yes. My report will more or less look the same as the one above.
Unless it's a question of going back to the old 'disable all Add-Ons'-”harrowing” and try them one by one.
(Swedish expression).
Edit.
No difference.
Tried without Internet Security. This, of course mainly concerns “FreeMyBrowser” and the two others.
I installed “Open in VLC media player” which eventually got accepted like tenminute wrote.

If it's just a question of updating AngularJS and jQuery, some scripts being too inferior...?

I was about to send “Chrome Store Foxified” my report when I saw that this was actually it.

On ”FreeMyBrowser” it says: ”The Chrome Extension has been successfully installed” while in reality it's unusable after the ”Install Temporarily”, and as you write: it's “uninstalled when Firefox closes”.
As reported above (regular install), getting the message: “Signing failed, max attempts reached while waiting for review to complete.” , “Banned 3rd-party JS library”: “Your add-on uses a JavaScript library we consider unsafe” and “AngularJS: We allow 1.5.9 and above; all previous versions are banned”, “jQuery versions older than 2.0 are not supported.....”.
......fixed Soon by Mozilla ?

Java Update: ”You already have the latest Java Platform on this system"
I have at least taken part of: [https://developer.mozilla.org/en/Add-ons/WebExtensions/Chrome_incompatibilities]

FreeMy... would also be very valuable in Firefox because of more possibilities.

@TheShivamUp
Copy link

@TheShivamUp TheShivamUp commented Aug 17, 2017

yes I got the same problem with it .

@melnation-com
Copy link

@melnation-com melnation-com commented Aug 12, 2018

12/Aug/2018
Just happened to me right now, was upgrading to 15.0.0.30, but ISP was on and off.. and it kinda off during the validation..

I can still install 15.0.0.30 if I just clicked "Install Unsigned" yet to test if it works or not.

Edit: the addon https://chrome.google.com/webstore/detail/nano-defender/ggolfgbegefeeoocgjbmkembbncoadlb If I just clicked "Install Unsigned" works for the site I use the addon specifically for, so nothing much alarming for me. Kinda reassuring it still works even AMO validation failed. You made a great addon to make it failsafe.

https://addons.mozilla.org/en-US/developers/upload/51528d0866934b0c9f1d6356e1bf0a55

Edit: 15.0.0.31 also 'failed' but still install'able via "install unsigned" -- 14/Aug/2018
https://addons.mozilla.org/en-US/developers/upload/f6d3a89fad61433bb9123fb87b658221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.