From fd1c557e77883bd00b8d85435ca99128b94006ce Mon Sep 17 00:00:00 2001 From: Franco Victorio Date: Tue, 6 Dec 2022 10:26:00 +0100 Subject: [PATCH 1/2] Fix compilation warnings in tests --- .../fixture-projects/consistent-build-info-names/contracts/A.sol | 1 + .../fixture-projects/consistent-build-info-names/contracts/B.sol | 1 + .../node_modules/dependency/contracts/Dep1.sol | 1 + .../node_modules/dependency/contracts/Dep2.sol | 1 + .../test/fixture-projects/project-with-scripts/contracts/a.sol | 1 + 5 files changed, 5 insertions(+) diff --git a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/A.sol b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/A.sol index ad5f5e77cb..2df470ed39 100644 --- a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/A.sol +++ b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/A.sol @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: UNLICENSED pragma solidity ^0.7.0; import "dependency/contracts/Dep1.sol"; diff --git a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/B.sol b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/B.sol index 0289d130fc..092fd24877 100644 --- a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/B.sol +++ b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/contracts/B.sol @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: UNLICENSED pragma solidity ^0.7.0; import "dependency/contracts/Dep1.sol"; diff --git a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep1.sol b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep1.sol index c3cbfee01f..5d15b30180 100644 --- a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep1.sol +++ b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep1.sol @@ -1 +1,2 @@ +// SPDX-License-Identifier: UNLICENSED pragma solidity ^0.7.0; diff --git a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep2.sol b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep2.sol index c3cbfee01f..5d15b30180 100644 --- a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep2.sol +++ b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/node_modules/dependency/contracts/Dep2.sol @@ -1 +1,2 @@ +// SPDX-License-Identifier: UNLICENSED pragma solidity ^0.7.0; diff --git a/packages/hardhat-core/test/fixture-projects/project-with-scripts/contracts/a.sol b/packages/hardhat-core/test/fixture-projects/project-with-scripts/contracts/a.sol index 19d44c5f96..1b8938dc93 100644 --- a/packages/hardhat-core/test/fixture-projects/project-with-scripts/contracts/a.sol +++ b/packages/hardhat-core/test/fixture-projects/project-with-scripts/contracts/a.sol @@ -1,2 +1,3 @@ +pragma solidity ^0.5.0; contract A {} From e45f8b4dd5ab5fcb511d31e110541640493f50a0 Mon Sep 17 00:00:00 2001 From: Franco Victorio Date: Tue, 6 Dec 2022 10:40:18 +0100 Subject: [PATCH 2/2] Omit noisy log in test --- .../consistent-build-info-names/hardhat.config.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/hardhat.config.js b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/hardhat.config.js index 38f2a55388..a53bbe1b77 100644 --- a/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/hardhat.config.js +++ b/packages/hardhat-core/test/fixture-projects/consistent-build-info-names/hardhat.config.js @@ -1,3 +1,7 @@ +// This project is compiled from scratch multiple times in the same test, which +// produces a lot of logs. We override this task to omit those logs. +subtask("compile:solidity:log:compilation-result", () => {}); + module.exports = { solidity: "0.7.3", };