Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snap builds #421

Merged
merged 2 commits into from Dec 18, 2019
Merged

Fix snap builds #421

merged 2 commits into from Dec 18, 2019

Conversation

@adam-stokes
Copy link
Contributor

@adam-stokes adam-stokes commented Dec 16, 2019

  • Use core18
  • Update the building section to be conformant with latest recommendations

Fixes #366

Signed-off-by: Adam Stokes battlemidget@users.noreply.github.com

- Use core18
- Update the building section to be conformant with latest recommendations

Fixes #366

Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
@jhthorsen jhthorsen self-requested a review Dec 17, 2019
Copy link
Member

@jhthorsen jhthorsen left a comment

It would be a great fix if Convos could be available as a snap again, but since I haven't worked with snaps in a while I have some comments/questions.

Thanks for the PR 👍

snap/local/README.md Outdated Show resolved Hide resolved
snap/local/README.md Outdated Show resolved Hide resolved
@jhthorsen
Copy link
Member

@jhthorsen jhthorsen commented Dec 17, 2019

if you hook up github with snapcraft.io, it'll use launchpad to automatically build snaps.

You said something like the above on IRC - Unfortunately, I don't understand what you're saying. Can you point me to a howto or something to set this up?

@adam-stokes
Copy link
Contributor Author

@adam-stokes adam-stokes commented Dec 17, 2019

You said something like the above on IRC - Unfortunately, I don't understand what you're saying. Can you point me to a howto or something to set this up?

There are a couple of ways to do this, one is through travis-ci:

https://tutorials.ubuntu.com/tutorial/continuous-snap-delivery-from-travis-ci#0

The other way is to hook it up through snapcraft.io directly:

https://snapcraft.io/build

This will auth against your github account and do the build automatically

snap/local/README.md Outdated Show resolved Hide resolved
@jhthorsen
Copy link
Member

@jhthorsen jhthorsen commented Dec 18, 2019

I will add the snippet below to the README after we've merged this:

[![Get Convos from the Snap Store](https://snapcraft.io/static/images/badges/en/snap-store-black.svg)](https://snapcraft.io/convos)
@jhthorsen
Copy link
Member

@jhthorsen jhthorsen commented Dec 18, 2019

Thank you so much for the two links! I've set it up through https://snapcraft.io/build now, but it's failing since we haven't merged this PR :)

https://build.snapcraft.io/user/Nordaaker/convos/768947

Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
@jhthorsen
Copy link
Member

@jhthorsen jhthorsen commented Dec 18, 2019

Awesome! Thank you 👍

@jhthorsen jhthorsen merged commit 30d99da into Nordaaker:master Dec 18, 2019
@adam-stokes adam-stokes deleted the adam-stokes:fix-snap-builds branch Dec 18, 2019
@jhthorsen jhthorsen added this to the 3.00 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.