Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted perl code to using promises, closes #420 #423

Merged
merged 1 commit into from Dec 21, 2019

Conversation

@jhthorsen
Copy link
Member

@jhthorsen jhthorsen commented Dec 21, 2019

  • Add "around_action" hook to catch rejected promises
  • Add "reason" argument to Convos::Core->connect()
  • Add Convos::Core::Connection->set_wanted_state_p() method
  • Add Convos::Core::Backend->handle_event_p()
  • Add Convos::Core::Backend->on()
  • Add Convos::Plugin::Paste::File->handle_event_p()
  • Add Convos::Plugin::Paste::File->to_message()
  • Add a bunch of new tests
  • Replaced all callback based methods with methods that return a promise
  • Replaced Mojo::IOLoop::ForkCall with Mojo::IOLoop::Subprocess
  • Replaced CONVOS_STEAL_NICK_INTERVAL with CONVOS_IRC_PERIDOC_INTERVAL
  • Replaced "$self" in the POD with the name of the actual object, like
    $core, $user, ...
  • Changes Convos::Core::Connection->wanted_state() to an attribute
  • Changed default CONVOS_CONNECT_DELAY from 3 to 4
  • Removed "get_user" WebSocket event
  • Removed "participants" API endpoint
  • Removed Convos::Core::Backend->emit_single()
  • Removed next_tick() from Convos::Util
  • Removed all blocking APIs
  • Removed delay() helper
  • Removed Mojo::IRC as a dependency
    • Mojo::IOLoop::Stream is now part of Convos::Core::Connection
    • IRC event handling is now in Convos::Core::Connection::Irc
  • Removed Convos::Core::Connection->participants()
  • Removed Convos::Core::Connection::Irc->participants()
  • Moved logic from Convos::Core::Connection::Irc->connect()
    to Convos::Core::Connection->connect()
  • Moved logic from Convos::Core::Connection::Irc->disconnect_p()
    to Convos::Core::Connection->disconnect_p()
  - Add "around_action" hook to catch rejected promises
  - Add "reason" argument to Convos::Core->connect()
  - Add Convos::Core::Connection->set_wanted_state_p() method
  - Add Convos::Core::Backend->handle_event_p()
  - Add Convos::Core::Backend->on()
  - Add Convos::Plugin::Paste::File->handle_event_p()
  - Add Convos::Plugin::Paste::File->to_message()
  - Add a bunch of new tests
  - Replaced all callback based methods with methods that return a promise
  - Replaced Mojo::IOLoop::ForkCall with Mojo::IOLoop::Subprocess
  - Replaced CONVOS_STEAL_NICK_INTERVAL with CONVOS_IRC_PERIDOC_INTERVAL
  - Replaced "$self" in the POD with the name of the actual object, like
    $core, $user, ...
  - Changes Convos::Core::Connection->wanted_state() to an attribute
  - Changed default CONVOS_CONNECT_DELAY from 3 to 4
  - Removed "get_user" WebSocket event
  - Removed "participants" API endpoint
  - Removed Convos::Core::Backend->emit_single()
  - Removed next_tick() from Convos::Util
  - Removed all blocking APIs
  - Removed delay() helper
  - Removed Mojo::IRC as a dependency
    * Mojo::IOLoop::Stream is now part of Convos::Core::Connection
    * IRC event handling is now in Convos::Core::Connection::Irc
  - Removed Convos::Core::Connection->participants()
  - Removed Convos::Core::Connection::Irc->participants()
  - Moved logic from Convos::Core::Connection::Irc->connect()
    to Convos::Core::Connection->connect()
  - Moved logic from Convos::Core::Connection::Irc->disconnect_p()
    to Convos::Core::Connection->disconnect_p()
@jhthorsen jhthorsen self-assigned this Dec 21, 2019
@jhthorsen jhthorsen added this to the 3.00 milestone Dec 21, 2019
@jhthorsen jhthorsen merged commit 47bd8c1 into master Dec 21, 2019
1 check passed
1 check passed
build
Details
@jhthorsen jhthorsen deleted the jhthorsen/420-promises branch Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.