Converted perl code to using promises, closes #420 #423
Conversation
- Add "around_action" hook to catch rejected promises
- Add "reason" argument to Convos::Core->connect()
- Add Convos::Core::Connection->set_wanted_state_p() method
- Add Convos::Core::Backend->handle_event_p()
- Add Convos::Core::Backend->on()
- Add Convos::Plugin::Paste::File->handle_event_p()
- Add Convos::Plugin::Paste::File->to_message()
- Add a bunch of new tests
- Replaced all callback based methods with methods that return a promise
- Replaced Mojo::IOLoop::ForkCall with Mojo::IOLoop::Subprocess
- Replaced CONVOS_STEAL_NICK_INTERVAL with CONVOS_IRC_PERIDOC_INTERVAL
- Replaced "$self" in the POD with the name of the actual object, like
$core, $user, ...
- Changes Convos::Core::Connection->wanted_state() to an attribute
- Changed default CONVOS_CONNECT_DELAY from 3 to 4
- Removed "get_user" WebSocket event
- Removed "participants" API endpoint
- Removed Convos::Core::Backend->emit_single()
- Removed next_tick() from Convos::Util
- Removed all blocking APIs
- Removed delay() helper
- Removed Mojo::IRC as a dependency
* Mojo::IOLoop::Stream is now part of Convos::Core::Connection
* IRC event handling is now in Convos::Core::Connection::Irc
- Removed Convos::Core::Connection->participants()
- Removed Convos::Core::Connection::Irc->participants()
- Moved logic from Convos::Core::Connection::Irc->connect()
to Convos::Core::Connection->connect()
- Moved logic from Convos::Core::Connection::Irc->disconnect_p()
to Convos::Core::Connection->disconnect_p()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
$core, $user, ...
to Convos::Core::Connection->connect()
to Convos::Core::Connection->disconnect_p()