Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds open mouth, red hear and kissing emojis #534

Merged
merged 3 commits into from Nov 24, 2020
Merged

Adds open mouth, red hear and kissing emojis #534

merged 3 commits into from Nov 24, 2020

Conversation

Megaf
Copy link
Contributor

@Megaf Megaf commented Nov 24, 2020 •
edited 

  ':open_mouth:' ':O',
  ':kissing:' ':-*',
  ':heart:' '<3',

馃槷 馃槜 鉂わ笍
Do I have to edit any other file/line as well?

@Megaf
Adds open mouth, red hear and kissing emojis
7aa29e5 
```
  ':open_mouth:' ':O',
  ':kissing:' ':-*',
  ':heart:' '<3',
```
jhthorsen
jhthorsen requested changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 馃憤 But could you:

  • Sort the lines in the object
  • The 鉂わ笍 Is already added
  • Could you also add support for (Y) = thumbs up?

@Megaf
Copy link
Contributor Author

Megaf commented Nov 24, 2020

There, thumbs up and all sorted.

@Megaf Megaf requested a review from jhthorsen November 24, 2020 23:35
@jhthorsen jhthorsen added this to the 5.xx milestone Nov 24, 2020
@jhthorsen
Copy link
Collaborator

Awesome 馃憤 Thank you

@jhthorsen jhthorsen merged commit 25631cb into convos-chat:master Nov 24, 2020
@Megaf Megaf deleted the add_emojis branch November 24, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhthorsen jhthorsen Awaiting requested review from jhthorsen

Assignees

@Megaf Megaf

Labels
enhancement
Projects
None yet
Milestone
5.xx
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Megaf @jhthorsen