Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM [nrf noup] cmake: Adopted to new multi image approach #2

Closed
wants to merge 1 commit into from

Conversation

tejlmand
Copy link

@tejlmand tejlmand commented Nov 15, 2019

This PR introduces the use of the new principle for creating multi image build.

It reverts the only nordic specific commit, so instead of merging this PR, I suggests that we start following upstream SHA in our manifest.


All occurrences of ${IMAGE} have been removed in order to adopt to the
new strategy used for multi image builds.

Signed-off-by: Torsten Rasmussen Torsten.Rasmussen@nordicsemi.no

All occurrences of ${IMAGE} have been removed in order to adopt to the
new strategy used for multi image builds.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand mentioned this pull request Nov 15, 2019
20 tasks
@carlescufi carlescufi changed the title [nrf noup] cmake: Adopted to new multi image approach DNM [nrf noup] cmake: Adopted to new multi image approach Nov 15, 2019
Copy link
Contributor

@SebastianBoe SebastianBoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

WIP

@mbolivar
Copy link

Same deal as tinycbor -- no diff from zephyrproject-rtos, so just point there

@tejlmand
Copy link
Author

Closing as: nrfconnect/sdk-nrf#1508
now points upstream

@tejlmand
Copy link
Author

Closing as: nrfconnect/sdk-nrf#1508
now points upstream

@tejlmand tejlmand closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants