Prepare npm packages #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add build setup for @kodbruket/vsf-storyblok-extension - Update config files etc.
With this approach we don't have to override vue-storefront-api's package.json file
zimme
force-pushed
the
zimme/prepare-npm-packages
branch
from
36c16bd
to
22f947d
Compare
These are provided by the module
|
@benjick You can review the code changes in this PR now, however it's still depending on the PR in vue-storefront so we'll need to hold off merging this those are merged. |
|
The failing tests are expected, until the vue-storefront changes are in |
benjick
approved these changes
May 16, 2019
benjick
force-pushed
the
master
branch
2 times, most recently
from
9e894ab
to
647f578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on vuestorefront/vue-storefront#2875 and vuestorefront/vue-storefront#2906