From 0fb7e22784eaee20c940eeebd5335182ee41cba2 Mon Sep 17 00:00:00 2001 From: jichenjc Date: Mon, 16 May 2022 02:51:53 +0000 Subject: [PATCH] remove used file --- hack/update-gofmt.sh | 21 ------- hack/verify-gofmt.sh | 31 ---------- hack/verify-golint.sh | 132 ------------------------------------------ 3 files changed, 184 deletions(-) delete mode 100755 hack/update-gofmt.sh delete mode 100755 hack/verify-gofmt.sh delete mode 100755 hack/verify-golint.sh diff --git a/hack/update-gofmt.sh b/hack/update-gofmt.sh deleted file mode 100755 index 81c9dc020e..0000000000 --- a/hack/update-gofmt.sh +++ /dev/null @@ -1,21 +0,0 @@ -#!/usr/bin/env bash - -# Copyright 2017 The Kubernetes Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -o errexit -set -o nounset -set -o pipefail - -find . -name "*.go" | grep -v "\/vendor\/" | xargs gofmt -s -w diff --git a/hack/verify-gofmt.sh b/hack/verify-gofmt.sh deleted file mode 100755 index 693412cc59..0000000000 --- a/hack/verify-gofmt.sh +++ /dev/null @@ -1,31 +0,0 @@ -#!/usr/bin/env bash -# Copyright 2017 The Kubernetes Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -o errexit -set -o nounset -set -o pipefail - -if ! which gofmt > /dev/null; then - echo "Can not find gofmt" - exit 1 -fi - -diff=$(find . -name "*.go" | grep -v "\/vendor\/" | xargs gofmt -s -d 2>&1) -if [[ -n "${diff}" ]]; then - echo "${diff}" - echo - echo "Please run hack/update-gofmt.sh" - exit 1 -fi diff --git a/hack/verify-golint.sh b/hack/verify-golint.sh deleted file mode 100755 index cfaa7ef770..0000000000 --- a/hack/verify-golint.sh +++ /dev/null @@ -1,132 +0,0 @@ -#!/usr/bin/env bash - -# Copyright 2014 The Kubernetes Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -o errexit -set -o pipefail - -KUBE_ROOT=$(dirname "${BASH_SOURCE}")/.. -#source "${KUBE_ROOT}/hack/lib/init.sh" - -#kube::golang::verify_go_version - -if ! which golint > /dev/null; then - echo 'Can not find golint, install with:' - echo 'go get -u github.com/golang/lint/golint' - exit 1 -fi - -cd "${KUBE_ROOT}" - -array_contains () { - local seeking=$1; shift # shift will iterate through the array - local in=1 # in holds the exit status for the function - for element; do - if [[ "$element" == "$seeking" ]]; then - in=0 # set in to 0 since we found it - break - fi - done - return $in -} - -# Check that the file is in alphabetical order -failure_file="${KUBE_ROOT}/hack/.golint_failures" -if ! diff -u "${failure_file}" <(LC_ALL=C sort "${failure_file}"); then - { - echo - echo "hack/.golint_failures is not in alphabetical order. Please sort it:" - echo - echo " LC_ALL=C sort -o hack/.golint_failures hack/.golint_failures" - echo - } >&2 - false -fi - -export IFS=$'\n' -# NOTE: when "go list -e ./..." is run within GOPATH, it turns the k8s.io/kubernetes -# as the prefix, however if we run it outside it returns the full path of the file -# with a leading underscore. We'll need to support both scenarios for all_packages. -all_packages=( - $(go list -e ./... | egrep -v "/(third_party|vendor|staging/src/k8s.io/client-go/pkg|generated|clientset_generated)" | sed -e 's|^k8s.io/kubernetes/||' -e "s|^_${KUBE_ROOT}/\?||") -) -failing_packages=( - $(cat $failure_file) -) -unset IFS -errors=() -not_failing=() -for p in "${all_packages[@]}"; do - # Run golint on package/*.go file explicitly to validate all go files - # and not just the ones for the current platform. - # Packages with a corresponding foo_test package will make golint fail - # with a useless error. Just ignore that, see golang/lint#68. - failedLint=$(golint "$p"/*.go 2>/dev/null) - array_contains "$p" "${failing_packages[@]}" && in_failing=$? || in_failing=$? - if [[ -n "${failedLint}" ]] && [[ "${in_failing}" -ne "0" ]]; then - errors+=( "${failedLint}" ) - fi - if [[ -z "${failedLint}" ]] && [[ "${in_failing}" -eq "0" ]]; then - not_failing+=( $p ) - fi -done - -# Check that all failing_packages actually still exist -gone=() -for p in "${failing_packages[@]}"; do - array_contains "$p" "${all_packages[@]}" || gone+=( "$p" ) -done - -# Check to be sure all the packages that should pass lint are. -if [ ${#errors[@]} -eq 0 ]; then - echo 'Congratulations! All Go source files have been linted.' -else - { - echo "Errors from golint:" - for err in "${errors[@]}"; do - echo "$err" - done - echo - echo 'Please review the above warnings. You can test via "golint" and commit the result.' - echo 'If the above warnings do not make sense, you can exempt this package from golint' - echo 'checking by adding it to hack/.golint_failures (if your reviewer is okay with it).' - echo - } >&2 - false -fi - -if [[ ${#not_failing[@]} -gt 0 ]]; then - { - echo "Some packages in hack/.golint_failures are passing golint. Please remove them." - echo - for p in "${not_failing[@]}"; do - echo " $p" - done - echo - } >&2 - false -fi - -if [[ ${#gone[@]} -gt 0 ]]; then - { - echo "Some packages in hack/.golint_failures do not exist anymore. Please remove them." - echo - for p in "${gone[@]}"; do - echo " $p" - done - echo - } >&2 - false -fi