Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10142: Extend variable_dict_from_file to allow reading yaml and csv files #525

Conversation

@amousset

This comment has been minimized.

Copy link
Member Author

amousset commented Feb 4, 2017

Not tested, do not merge for now.

@@ -0,0 +1,67 @@
#####################################################################################
# Copyright 2015 Normation SAS

This comment has been minimized.

Copy link
@peckpeck

peckpeck Feb 4, 2017

Contributor

2017

"args" slist => { "${variable_prefix}", "${variable_name}", "${file_name}" };

# define the variable within the variable_prefix namespace
"${variable_prefix}.${variable_name}" data => readdata("${file_name}", "${file_type}");

This comment has been minimized.

Copy link
@peckpeck

peckpeck Feb 4, 2017

Contributor

There is an ordering problem, file_type is defined in pass2, which means:

  • the file is read twice
  • the output class that are defined at first pass will be wrong
@jooooooon

This comment has been minimized.

Copy link
Member

jooooooon commented Feb 5, 2017

Not tested, do not merge for now.

It would be good to have an automatic test for this method (or extend the existing one if applicable) too, so it's not just your tests, but all tests for the whole of ncf's future :)

@peckpeck

This comment has been minimized.

Copy link
Contributor

peckpeck commented Feb 22, 2017

ping @amousset

@peckpeck

This comment has been minimized.

Copy link
Contributor

peckpeck commented Jul 6, 2017

ping @amousset

@peckpeck

This comment has been minimized.

Copy link
Contributor

peckpeck commented Oct 10, 2017

Closed until the agent includes yaml and xml

@peckpeck peckpeck closed this Oct 10, 2017
@amousset amousset reopened this Jul 4, 2019
@amousset amousset force-pushed the amousset:ust_10142/extend_variable_dict_from_file_to_allow_reading_yaml_and_csv_files branch from 56220f8 to 0d0e02e Jul 4, 2019
@amousset amousset removed the Very old PR label Jul 4, 2019
@amousset amousset force-pushed the amousset:ust_10142/extend_variable_dict_from_file_to_allow_reading_yaml_and_csv_files branch from 0d0e02e to 04ec3fd Jul 4, 2019
@amousset

This comment has been minimized.

Copy link
Member Author

amousset commented Jul 4, 2019

Commit modified

@amousset amousset force-pushed the amousset:ust_10142/extend_variable_dict_from_file_to_allow_reading_yaml_and_csv_files branch from 04ec3fd to c333abe Jul 4, 2019
@amousset

This comment has been minimized.

Copy link
Member Author

amousset commented Jul 4, 2019

PR replaced by #998

@amousset amousset closed this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.