Fixes #14293: ncf 4.1 is not compatible anymore with agent 3.1 #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Feb 11, 2019
| } | ||
|
|
||
|
|
||
| bundle agent push_dry_run_mode(mode) |
There was a problem hiding this comment.
I think we should call set_dry_run_mode to fail in this case
amousset
reviewed
Feb 11, 2019
|
|
||
| } | ||
|
|
||
| bundle agent pop_dry_run_mode() |
ncharles
force-pushed
the
bug_14293/ncf_4_1_is_not_compatible_anymore_with_agent_3_1
branch
from
f6ec810
to
6638165
Compare
|
Commit modified |
amousset
reviewed
Feb 11, 2019
| "abort" usebundle => _abort("unsupported_dryrun", "Dry-run mode is not compatible with this agent. Stopping immediately to prevent any unwanted change."), | ||
| action => immediate_ignore_dry_run; | ||
|
|
||
| reports: |
There was a problem hiding this comment.
you can remove the reports here
ncharles
force-pushed
the
bug_14293/ncf_4_1_is_not_compatible_anymore_with_agent_3_1
branch
from
6638165
to
720f669
Compare
|
Commit modified |
amousset
approved these changes
Feb 11, 2019
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14293