From be6d258649a8a08cc2008d4333f5372562d03526 Mon Sep 17 00:00:00 2001
From: Matthieu CERDA <matthieu.cerda@normation.com>
Date: Tue, 31 Mar 2015 11:55:02 +0200
Subject: [PATCH] Fixes #5653: Prevent the rudder-jetty init script from
 outputting false FAILED messages

---
 rudder-jetty/SOURCES/Makefile                 |  1 +
 ...tty-init-prevent-false-failed-starts.patch | 62 +++++++++++++++++++
 rudder-jetty/SOURCES/jetty-init-sles.patch    | 15 ++---
 3 files changed, 71 insertions(+), 7 deletions(-)
 create mode 100644 rudder-jetty/SOURCES/jetty-init-prevent-false-failed-starts.patch

diff --git a/rudder-jetty/SOURCES/Makefile b/rudder-jetty/SOURCES/Makefile
index b40bd1baa..62872085b 100644
--- a/rudder-jetty/SOURCES/Makefile
+++ b/rudder-jetty/SOURCES/Makefile
@@ -48,6 +48,7 @@ localdepends: ./jetty7
 	patch -p0 -s < jetty-init-stop-fix.patch
 	patch -p0 -s < jetty-init-sizecheck.patch
 	patch -p0 -s < jetty-init-use-rudder-jetty-defaults.patch
+	patch -p0 -s < jetty-init-prevent-false-failed-starts.patch
 
 	cp ./jetty7/bin/jetty.sh ./jetty7/bin/jetty-debian.sh
 	cp ./jetty7/bin/jetty.sh ./jetty7/bin/jetty-sles.sh
diff --git a/rudder-jetty/SOURCES/jetty-init-prevent-false-failed-starts.patch b/rudder-jetty/SOURCES/jetty-init-prevent-false-failed-starts.patch
new file mode 100644
index 000000000..c79d244b4
--- /dev/null
+++ b/rudder-jetty/SOURCES/jetty-init-prevent-false-failed-starts.patch
@@ -0,0 +1,62 @@
+--- jetty7/bin/jetty.sh	2015-03-31 12:08:37.319515629 +0200
++++ jetty7/bin/jetty.sh	2015-03-31 12:12:16.660886179 +0200
+@@ -117,10 +117,10 @@
+   do
+     sleep 4
+     [ -z "$(grep STARTED $1 2>/dev/null)" ] || return 0
++
+     [ -z "$(grep STOPPED $1 2>/dev/null)" ] || return 1
+     [ -z "$(grep FAILED $1 2>/dev/null)" ] || return 1
+-    local PID=$(cat "$2" 2>/dev/null) || return 1
+-    kill -0 "$PID" 2>/dev/null || return 1
++
+     echo -n ". "
+   done
+ 
+@@ -358,8 +358,8 @@
+ then
+   JETTY_STATE=$JETTY_HOME/jetty.state
+ fi
++
+ JAVA_OPTIONS+=("-Djetty.state=$JETTY_STATE")
+-rm -f $JETTY_STATE
+ 
+ ##################################################
+ # Set default JVM parameters, to be
+@@ -487,7 +487,15 @@
+       exit
+     fi
+ 
+-    if [ $UID -eq 0 ] && type start-stop-daemon > /dev/null 2>&1 
++    if [ $(ps aux|grep -cE "[j]ava .* /opt/rudder/jetty7/start.jar") -ne 0 ]
++    then
++        echo "already running."
++        exit 0
++    fi
++
++    rm -f ${JETTY_STATE}
++
++    if [ $UID -eq 0 ] && type start-stop-daemon > /dev/null 2>&1
+     then
+       unset CH_USER
+       if [ -n "$JETTY_USER" ]
+@@ -561,7 +569,9 @@
+         sleep 1
+       done
+ 
++      rm -f ${JETTY_STATE}
+       rm -f "$JETTY_PID"
++
+       echo OK
+     else
+       PID=$(cat "$JETTY_PID" 2>/dev/null)
+@@ -580,7 +590,9 @@
+         sleep 1
+       done
+ 
++      rm -f ${JETTY_STATE}
+       rm -f "$JETTY_PID"
++
+       echo OK
+     fi
+ 
diff --git a/rudder-jetty/SOURCES/jetty-init-sles.patch b/rudder-jetty/SOURCES/jetty-init-sles.patch
index af2b0ce16..cc7960cbb 100644
--- a/rudder-jetty/SOURCES/jetty-init-sles.patch
+++ b/rudder-jetty/SOURCES/jetty-init-sles.patch
@@ -1,15 +1,15 @@
---- jetty7/bin/jetty-sles.sh	2014-03-13 14:05:22.080605960 +0100
-+++ jetty7/bin/jetty-sles.sh	2014-03-13 14:06:07.388526581 +0100
-@@ -464,7 +464,7 @@
-       exit
-     fi
+--- jetty7/bin/jetty-sles.sh	2014-11-21 18:18:10.761944184 +0100
++++ jetty7/bin/jetty-sles.sh	2014-11-21 18:17:40.897795646 +0100
+@@ -512,7 +512,7 @@
  
--    if [ $UID -eq 0 ] && type start-stop-daemon > /dev/null 2>&1 
+     rm -f ${JETTY_STATE}
+ 
+-    if [ $UID -eq 0 ] && type start-stop-daemon > /dev/null 2>&1
 +    if [ "$START_STOP_DAEMON" = "1" ] && [ $UID -eq 0 ] && type start-stop-daemon > /dev/null 2>&1
      then
        unset CH_USER
        if [ -n "$JETTY_USER" ]
-@@ -521,7 +521,7 @@
+@@ -570,7 +570,7 @@
  
    stop)
      echo -n "Stopping Jetty: "
@@ -18,3 +18,4 @@
        start-stop-daemon -K -p"$JETTY_PID" -d"$JETTY_HOME" -a "$JAVA" -s HUP
        
        TIMEOUT=30
+