Fixes #5866: ncf API hooks don't always fail on errors #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +69,7 @@ git add "ncf_techniques/${TECHNIQUE}" | |||
| git commit -q -m "Commit meta Technique ${TECHNIQUE}" | |||
|
|
|||
| # Reload technique library, bypass the ssl verification since we are on localhost | |||
| STEP="Reloading technique library" | |||
| curl -s -f -k "https://localhost/rudder/api/techniqueLibrary/reload" | |||
|
|
|||
| if [ "$?" -eq 22 ]; then | |||
There was a problem hiding this comment.
This can never happen now this script is set -e. Please remove this if statement, but include the (better) error message below in the STEP variable above.
peckpeck
force-pushed
the
bug_5866/ncf_api_hooks_don_t_always_fail_on_errors
branch
from
bb18f8f
to
b70e987
Compare
|
@jooooooon updated |
jooooooon
added a commit
that referenced
this pull request
Jan 15, 2015
…ways_fail_on_errors Fixes #5866: ncf API hooks don't always fail on errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/5866