Fixes #17570: Trigger promises generation when promoting a node to relay #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
ElaadF
force-pushed
the
bug_17570/trigger_promises_generation_when_promoting_a_node_to_relay
branch
from
02344f4
to
9ca42cb
Compare
|
Are you sure it needs a reload ? i don't think because rule creation already reloads |
|
I don't see where the reload is performed, no eventlog indicates this and it seems that in https://github.com/Normation/rudder/blob/master/webapp/sources/rudder/rudder-core/src/main/scala/com/normation/rudder/repository/ldap/LDAPRuleRepository.scala#L186 there is no reload at this point |
| @@ -59,6 +61,7 @@ class ScaleOutRelayService( | |||
| } else { | |||
| nodeInfos.succeed | |||
| } | |||
| _ <- clearCacheService.clearNodeConfigurationCache(storeEvent = true, actor) | |||
There was a problem hiding this comment.
In fact you should trigger a deployment not delete the whole configurationCache.
We used to call deploy api that only starts a deployment:
asyncDeploymentAgent ! AutomaticStartDeployment(modId, actor)
with
, asyncDeploymentAgent : AsyncDeploymentActor
you can put it in the yield section
ElaadF
force-pushed
the
bug_17570/trigger_promises_generation_when_promoting_a_node_to_relay
branch
from
9ca42cb
to
8aa4f46
Compare
|
Commit modified |
VinceMacBuche
approved these changes
May 29, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17570