Fixes #9995: Forbid modification of properties set by datasource #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,23 +67,34 @@ import java.io.PipedOutputStream | |||
| import com.zaxxer.nuprocess.NuProcessBuilder | |||
| import java.util.Arrays | |||
| import com.normation.rudder.domain.nodes.NodeInfo | |||
| import com.normation.rudder.datasources.DataSourceRepository | |||
|
|
|||
| class NodeApiService8 ( | |||
There was a problem hiding this comment.
Needs to be done in NodeApiService5, maybe we can always use nodeAPI8Service and remove NodeApi5Service
|
PR rebased |
fanf
force-pushed
the
bug_9995/forbid_modification_of_properties_set_by_datasource
branch
from
2211dcf
to
844dcee
Compare
|
OK, merging this PR |
fanf
deleted the
bug_9995/forbid_modification_of_properties_set_by_datasource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9995