Fixes #11449: Allow variable as directive parameters in regexp validated inputs #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close for now, this needs to be tested |
ncharles
reviewed
Oct 13, 2017
| @@ -53,14 +53,14 @@ case class RegexConstraint(pattern: String, errorMsg: String) extends HashcodeCa | |||
|
|
|||
| val compiled = Pattern.compile(pattern) | |||
|
|
|||
| val variablePattern = Pattern.compile(".*\\$\\{.*\\}.*") | |||
There was a problem hiding this comment.
i fear it may be a bit too eager
There was a problem hiding this comment.
well, actually, i can't see why it should be an issue
There was a problem hiding this comment.
Yes we don't want to analyze it deeply do it does not need to be perfect matches for cases i tested ... (one var, two vars, var inside a var ... )
There was a problem hiding this comment.
I updated the regexp so it's less eager (added ? after * so it matches as less possible)
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_11449/hosts_technique_does_not_allow_to_use_sys_ipv4_or_any_other_variable
branch
from
5d5e881
to
0da78d3
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_11449/hosts_technique_does_not_allow_to_use_sys_ipv4_or_any_other_variable
branch
from
0da78d3
to
d26155d
Compare
VinceMacBuche
changed the title
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11449