New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14599: Rudder postgres unit test are broken #2179
Fixes #14599: Rudder postgres unit test are broken #2179
Conversation
jdbc.url = jdbc:postgresql://localhost:5432/test | ||
jdbc.username = test | ||
jdbc.password = test | ||
jdbc.url = jdbc:postgresql://localhost:55432/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that specific to your own environement ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally!
@@ -144,26 +144,27 @@ class ReportsTest extends DBCommon { | |||
val reports = ( | |||
Map[String, Seq[Reports]]() + | |||
node("n0")( | |||
("hasPolicyServer-root", "d1", 1, "common", "EndRun", run1, "result_success", "End execution") | |||
// ruleId dirId serial comp keyVal execTime severity msg | |||
("rudder", "run", 0, "end", "", run1, "control", "End execution") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's so much better :))
Commit modified |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
434cd8e
to
9441ca5
Compare
https://issues.rudder.io/issues/14599