Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15095: Missing log on hooks for generation #2269

Conversation

@fanf
Copy link
Member

fanf commented Jun 15, 2019

@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 15, 2019

PR updated with a new commit

@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 15, 2019

PR rebased

@fanf fanf force-pushed the fanf:bug_15095/missing_log_on_hooks_for_generation branch from 7d6a150 to 7d6c1a3 Jun 15, 2019
@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 16, 2019

PR updated with a new commit

1 similar comment
@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 16, 2019

PR updated with a new commit

@fanf fanf force-pushed the fanf:bug_15095/missing_log_on_hooks_for_generation branch 2 times, most recently from 20e7612 to 68aa199 Jun 16, 2019
@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 16, 2019

PR updated with a new commit

@Normation-Quality-Assistant

This comment has been minimized.

Copy link

Normation-Quality-Assistant commented Jun 17, 2019

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2269
-- Your faithful QA
Kant merge: "Happiness is not an ideal of reason, but of imagination."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/11371/console)

@fanf

This comment has been minimized.

Copy link
Member Author

fanf commented Jun 17, 2019

OK, squash merging this PR

@fanf fanf force-pushed the fanf:bug_15095/missing_log_on_hooks_for_generation branch from 7ed94c3 to 0344112 Jun 17, 2019
@fanf fanf merged commit 0344112 into Normation:branches/rudder/5.0 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.