Fixes #6005: sort the reports execution not by date, but by insertion #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
force-pushed
the
bug_6005/dev/report_sorted_by_insertion
branch
from
c6a8df1
to
20d78e0
Compare
| @@ -46,6 +46,8 @@ trait RoReportsExecutionRepository { | |||
|
|
|||
| /** | |||
| * Find the last execution of nodes, whatever is its state. | |||
| * Last execution is defined as "the last executions that have been inserted in the database", | |||
| * and do not rely on date (which can change too often) | |||
There was a problem hiding this comment.
Could you detail a little more, even referencing this bug, so that in the future we know why we choose that strange sorting order ?
ncharles
force-pushed
the
bug_6005/dev/report_sorted_by_insertion
branch
from
20d78e0
to
2025b63
Compare
fanf
added a commit
that referenced
this pull request
Dec 16, 2014
…nsertion Fixes #6005: sort the reports execution not by date, but by insertion
| LEFT JOIN ruddersysevents AS R | ||
| ON T.nodeid = R.nodeid AND T.executiontimestamp = R.executiontimestamp | ||
| GROUP BY T.nodeid, T.executiontimestamp | ||
| ) AS S WHERE testreport.date = S.executiontimestamp AND testreport.nodeid=S.nodeid; |
There was a problem hiding this comment.
I may be tired, but I don't understand where this testreport comes from. Am I missing something or is this a leftover from something else?
There was a problem hiding this comment.
it is a leftover ! i'll fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.