Fixes #6090: Node breakdown pie chart on homepage may be of different size #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about that correction because now, even if the are of the same size, they are not aligned as soon as the number of line of legend is not the same on all nodes, and the result is very strange. I looked and didn't find any option to give the donut OR the legend a fixed heigh. Sad. So, it would be nice to look if a better solution is needed (else, we will habe to choose between the two bad ones). |
VinceMacBuche
force-pushed
the
bug_6090/node_breakdown_pie_chart_on_homepage_may_be_of_different_size
branch
from
99e8e48
to
4decc7c
Compare
|
@fanf updated with new idea (two graphs, one withou legend, one with only legend) |
|
The result is perfect! |
fanf
added a commit
that referenced
this pull request
Jan 14, 2015
…e_chart_on_homepage_may_be_of_different_size Fixes #6090: Node breakdown pie chart on homepage may be of different size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/6090