Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd directions API redundancy with mapbox #2
Conversation
NoryDev
merged commit 4994d01
into
master
Aug 24, 2017
NoryDev
deleted the
mapbox-alternative-to-osrm
branch
Aug 24, 2017
This comment has been minimized.
This comment has been minimized.
simison
commented
Aug 24, 2017
|
Mapbox actually is pretty cool company; they publish a lot of their code open source and they even pay for OSRM development currently. https://wiki.openstreetmap.org/wiki/Open_Source_Routing_Machine#History |
This comment has been minimized.
This comment has been minimized.
simison
commented
Aug 24, 2017
•
|
Lemme know if you want to use MapBox APIs, you can piggyback on Hitchwiki's account. |
This comment has been minimized.
This comment has been minimized.
|
@simison great, I did not know! I made myself an account on Mapbox anyway, so I'm fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
NoryDev commentedAug 24, 2017
•
edited
OSRM has been down, triggered this redundancy implementation.
the
:mapboxsymbol passed to API should probably be more dynamic so that wrapper can be changed without modifying the codeI'm not very happy with mapbox, it's not free nor open source. On the positive side, they probably use OSRM in the back, as it's the same API, so few code change neededEDIT: see comment in thread