178956146 - Update i18n-nationality to use correct nationalities for Nigeria and Niger #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJunyuan
approved these changes
Jul 21, 2021
causztic
force-pushed
the
178956146-fix-nigerian-nigerien-nationality
branch
from
4b5a278
to
6f7f1f0
Compare
causztic
commented
Jul 21, 2021
| @@ -10,9 +10,9 @@ | |||
| "@govtechsg/decentralized-renderer-react-components": "3.3.0", | |||
| "@govtechsg/oa-schemata": "^1.8.0", | |||
| "@hot-loader/react-dom": "^16.11.0", | |||
| "@notarise-gov-sg/i18n-nationality": "~1.2.0", | |||
There was a problem hiding this comment.
this versioning is loosened as we are in control of the package now
HJunyuan
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review:
Check out https://github.com/Notarise-gov-sg/i18n-nationality and diff to verify that the change makes sense