Skip to content

fix: apply list_start_index for numbered_list #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

fix: apply list_start_index for numbered_list #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7175d
fix: apply list_start_index for numbered_list
ferrariRoma Oct 1, 2025
b457b11
fix: handle zero based index
ferrariRoma Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/notion-types/src/block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ export interface BulletedListBlock extends BaseTextBlock {

export interface NumberedListBlock extends BaseTextBlock {
type: 'numbered_list'
format?: BaseTextBlock['format'] & {
list_start_index?: number
}
}

export interface HeaderBlock extends BaseTextBlock {
Expand Down
6 changes: 5 additions & 1 deletion packages/react-notion-x/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ export const getListNumber = (blockId: string, blockMap: BlockMap) => {
return
}

return group.indexOf(blockId) + 1
const groupIndex = group.indexOf(blockId) + 1
const startIndex = blockMap[blockId]?.value.format?.list_start_index
return blockMap[blockId]?.value.type === 'numbered_list'
? (startIndex ?? groupIndex)
: groupIndex
}

export const getListNestingLevel = (
Expand Down