[Bug]: Layout management and side bars asylum in Mac Desktop App

[fascox]

Bug Description

The layout management functionality breaks the sidebar controls.

• The Hide/Show buttons for the left and right sidebars no longer work correctly.
• The "Swap the session e file browser sides" button behaves incorrectly.
• The Left Hide/Show button controls the right sidebar instead of the left.
• The Right Hide/Show button controls the left sidebar instead of the right.

This indicates that the sidebar button references are incorrectly mapped after the layout is updated.

Steps to Reproduce

Steps to reproduce:

1. Click the “Swap Session and File Browser Sides” button.
2. Try hiding and showing the sidebars.

Expected Behavior

hiding and showing buttons should control the correct sidebar

Actual Behavior

the sidebar controls behave incorrectly after the swap.

Affected Component

Other

Messaging Platform (if gateway-related)

No response

Debug Report

*

Operating System

MacOS Sequoia 15.7.7

Python Version

3.11.15

Hermes Version

0.18.2

Additional Logs / Traceback (optional)

Root Cause Analysis (optional)

No response

Proposed Fix (optional)

No response

Are you willing to submit a PR for this?

• I'd like to fix this myself and submit a PR

[GottZ]

This was generated by AI during triage.

Summary

One PR addresses #66357. #66458 correctly targets the titlebar’s physical-edge toggle mapping after a pane flip, but its controller rebinding conflicts with the layout tree’s semantic side ownership and its listener change introduces a TypeScript error.

Related pull requests

• fix(desktop): swap sidebar toggle mappings when panes are flipped (#66357) #66458 partial — (+40/-12) — partial fix: The titlebar diff swaps the left/right open-state and toggle targets when panes are flipped, addressing the reported physical-edge behavior. Consistent with the contributor keep_open review on fix(desktop): swap sidebar toggle mappings when panes are flipped (#66357) #66458, the patch still needs correction: retain semantic controller bindings, map actionId together with each titlebar target, and replace the invalid listen()-based unsubscribe path that causes TS2322 at apps/desktop/src/components/pane-shell/tree/store.ts:547.

Suggested consolidation

Keep #66458 open with a salvage path: preserve its flip-aware physical-edge mapping in apps/desktop/src/app/shell/titlebar-controls.tsx, extend that mapping to actionId, remove the double-swapping controller rebinding, and use an API that actually returns an unsubscribe function if rebinding remains necessary. This follows the contributor’s keep_open review while requiring the documented semantic-side and CI blockers to be resolved; there are no duplicate PRs to close.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I66357(["issue #66357 (open)"])
    P66458["PR #66458 (open)"]
    P66458 -.->|partial| I66357
    class I66357 open
    class I66357 target
    class P66458 open
    click I66357 "https://github.com/NousResearch/hermes-agent/issues/66357"
    click P66458 "https://github.com/NousResearch/hermes-agent/pull/66458"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 1 pull request and 1 issue in this complex. Each diff was read against this issue; Assessment working set: 5 kB of PR diffs, 2 kB of issue/PR text, 3 kB of discussion (2 comments), 1 verify verdict. verdicts reflect diff content, not PR titles. Part of an automated triage batch.