Don't fall thru when v3 feed failed #1253

Closed
feiling opened this Issue Aug 25, 2015 · 1 comment

Projects

None yet

4 participants

@feiling
Contributor
feiling commented Aug 25, 2015

In ServiceIndexResourceV3Provider.TryCreate(), when there are errors connecting to a v3 feed, the method returns (false, null). This allows fall thru and cause the feed to be treated as V2. We should stop the fall thru instead.

@feiling feiling added this to the 3.2 milestone Aug 25, 2015
@feiling feiling self-assigned this Aug 25, 2015
@feiling feiling added a commit to NuGetArchive/NuGet3 that referenced this issue Aug 28, 2015
@feiling feiling Fix of NuGet/Home#1253: Don't fall thru when v3 feed failed
Now if there is a failure, an exception will get thrown so GetResource fails immediately so no fall thru will happens. Also the V3 resource is cached only when it is successfully created.
8cbf11a
@feiling feiling added a commit to NuGetArchive/NuGet3 that referenced this issue Aug 28, 2015
@feiling feiling Fix of NuGet/Home#1253: Don't fall thru when v3 feed failed
Now if there is a failure, an exception will get thrown so GetResource fails immediately so no fall thru will happens. Also the V3 resource is cached only when it is successfully created.
f4398b1
@emgarten
Contributor
@emgarten emgarten closed this Aug 28, 2015
@feiling feiling was unassigned by yishaigalatzer Sep 1, 2015
@MeniZalzman MeniZalzman added 3 - Done and removed 2 - Working labels Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment