New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack support for csproj + project.json #1689

Closed
mteper opened this Issue Nov 5, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@mteper

mteper commented Nov 5, 2015

I am having no luck building a NuGet package for IntacctClient (see https://github.com/el-loco/IntacctClient)

Here's build output:

nuget pack "C:\projects\intacctclient\IntacctClient.csproj" -Properties "Configuration=Release;Platform=AnyCPU" -OutputDirectory "C:\Users\appveyor\AppData\Local\Temp\1\v0q0xxfwxi"
MSBuild auto-detection: using msbuild version '14.0' from 'C:\Program Files (x86)\MSBuild\14.0\bin'.
Attempting to build package from 'IntacctClient.csproj'.
Packing files from 'C:\projects\intacctclient\bin\Release'.
WARNING: Unable to extract metadata from 'IntacctClient.dll'.
Using 'IntacctClient.nuspec' for metadata.
Value cannot be null or an empty string.
Parameter name: profileValue
Command exited with code 1
@mteper

This comment has been minimized.

Show comment
Hide comment
@mteper

mteper Nov 5, 2015

This appears similar to #1267.

mteper commented Nov 5, 2015

This appears similar to #1267.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Nov 5, 2015

Contributor

It is the same as 1267, nuget.exe pack does not support project.json projects. You will need to pack using a nuspec.

Contributor

emgarten commented Nov 5, 2015

It is the same as 1267, nuget.exe pack does not support project.json projects. You will need to pack using a nuspec.

@mteper

This comment has been minimized.

Show comment
Hide comment
@mteper

mteper Nov 6, 2015

OK, that worked. Is there an issue I can follow for adding support for building from .csproj?

mteper commented Nov 6, 2015

OK, that worked. Is there an issue I can follow for adding support for building from .csproj?

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Dec 11, 2015

This will be the feature tracking it (renaming)

yishaigalatzer commented Dec 11, 2015

This will be the feature tracking it (renaming)

@yishaigalatzer yishaigalatzer changed the title from Unable to create nupkg, error for parameter name: profileValue. to Support nuget package proj.csproj - When the project is using project.json Dec 11, 2015

@yishaigalatzer yishaigalatzer added this to the 3.4 milestone Dec 11, 2015

@gregjhogan

This comment has been minimized.

Show comment
Hide comment
@gregjhogan

gregjhogan Feb 13, 2016

When I have project.json and MyProject.nuspec, I expected the dependencies to be picked up out of the project.json file. That does not seem to be the case.

I am running
nuget pack MyProject.csproj -Properties Configuration=release -IncludeReferencedProjects

Example with no <dependencies></dependencies> specified

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>$id$</id>
    <version>$version$</version>
    <authors>$author$</authors>
    <owners>$author$</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>$description$</description>
    <releaseNotes>$releaseNotes$</releaseNotes>
  </metadata>
</package>

Before I had a project.json this magically picked up all my nuget package dependencies (I guess out of packages.config)

gregjhogan commented Feb 13, 2016

When I have project.json and MyProject.nuspec, I expected the dependencies to be picked up out of the project.json file. That does not seem to be the case.

I am running
nuget pack MyProject.csproj -Properties Configuration=release -IncludeReferencedProjects

Example with no <dependencies></dependencies> specified

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>$id$</id>
    <version>$version$</version>
    <authors>$author$</authors>
    <owners>$author$</owners>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>$description$</description>
    <releaseNotes>$releaseNotes$</releaseNotes>
  </metadata>
</package>

Before I had a project.json this magically picked up all my nuget package dependencies (I guess out of packages.config)

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Feb 13, 2016

Contributor

@gregjhogan project.json is not being used at all by pack today. Project.json can contain all of the same metadata as the nuspec file so there may not be a nuspec + project.json pack scenario in the future.

Contributor

emgarten commented Feb 13, 2016

@gregjhogan project.json is not being used at all by pack today. Project.json can contain all of the same metadata as the nuspec file so there may not be a nuspec + project.json pack scenario in the future.

@yishaigalatzer yishaigalatzer modified the milestones: 3.4 Beta, 3.4 RTM Feb 25, 2016

@yishaigalatzer yishaigalatzer modified the milestones: 3.4 RTM, 3.4 RTM - Triage Mar 11, 2016

@yishaigalatzer yishaigalatzer changed the title from Support nuget package proj.csproj - When the project is using project.json to Pack support for csproj + project.json Mar 12, 2016

@yishaigalatzer yishaigalatzer modified the milestones: 3.5 Beta, 3.4 RTM - Triage Mar 12, 2016

@yishaigalatzer yishaigalatzer assigned toddm and unassigned emgarten Mar 12, 2016

@toddm

This comment has been minimized.

Show comment
Hide comment
@toddm

toddm Apr 4, 2016

Pushed to Dev

toddm commented Apr 4, 2016

Pushed to Dev

@toddm toddm closed this Apr 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment