New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative file path for "DefaultPushSource" #1746

Closed
LarterStyles opened this Issue Nov 20, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@LarterStyles

LarterStyles commented Nov 20, 2015

As far as I can tell, the "DefaultPushSource" configuration key doesn't allow you to specify a relative file path.

This works:

<add key="DefaultPushSource" value="C\Source\Project\CustomFeed" />

This doesn't:

<add key="DefaultPushSource" value="CustomFeed" />

This causes issues when executing builds + generating packages from a build server which may not even have a C:\

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Nov 20, 2015

You can always define the settings on the build server proper, so that should give you a workaround. Or better yet push explicitly to a known folder in the command itself

yishaigalatzer commented Nov 20, 2015

You can always define the settings on the build server proper, so that should give you a workaround. Or better yet push explicitly to a known folder in the command itself

@yishaigalatzer yishaigalatzer added this to the Client-VNext milestone Nov 20, 2015

@spadapet spadapet added the Area: Push label Apr 8, 2016

@spadapet spadapet modified the milestones: 3.5 RC, Client-VNext Apr 8, 2016

@spadapet

This comment has been minimized.

Show comment
Hide comment
@spadapet

spadapet Apr 8, 2016

Also need to make relative paths work as normal sources:
nuget push foo.nupkg -Source packages
nuget push foo.nupkg -Source ..\packages
nuget push foo.nupkg -Source .\packages

spadapet commented Apr 8, 2016

Also need to make relative paths work as normal sources:
nuget push foo.nupkg -Source packages
nuget push foo.nupkg -Source ..\packages
nuget push foo.nupkg -Source .\packages

@spadapet spadapet self-assigned this Apr 8, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue Apr 30, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 2, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

spadapet added a commit to NuGet/NuGet.Client that referenced this issue May 3, 2016

@spadapet

This comment has been minimized.

Show comment
Hide comment
@spadapet

spadapet May 3, 2016

I'll open a new issue for "push -Source foo" being relative. I don't want the change for that to be mixed up with the change for this fix.

spadapet commented May 3, 2016

I'll open a new issue for "push -Source foo" being relative. I don't want the change for that to be mixed up with the change for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment