New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuspec version range should override -IncludeReferencedProjects version #1983

Closed
StevenLiekens opened this Issue Jan 24, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@StevenLiekens

StevenLiekens commented Jan 24, 2016

The ÌncludeReferencedProjects option ignores version range restrictions in nuspec files.

I have a solution that contains two projects that need to be packaged: a master project and a referenced slave project.

solution explorer

The master project has a nuspec file that configures a dependency with a version restriction on the slave project.

<package >
  <metadata>
    <id>Master</id>
    <version>1.0.0</version>
    <title>Master</title>
    <authors>Steven</authors>
    <description>Master</description>
    <dependencies>
      <dependency id="Slave" version="[1,2)" />
    </dependencies>
  </metadata>
</package>

The slave project has a nuspec file too, for integration with the IncludeReferencedProjects option.

<package >
  <metadata>
    <id>Slave</id>
    <version>1.0.0</version>
    <title>Slave</title>
    <authors>Steven</authors>
    <description>Slave</description>
  </metadata>
</package>

When I execute nuget pack -IncludeReferencedProjects Master.csproj, the package is created without a version range restriction.

Expected result

expected result

Actual result

actual result

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Jan 26, 2016

Good catch, I don't see us jumping on this right away, so moving to vNext and marking as up for grabs

yishaigalatzer commented Jan 26, 2016

Good catch, I don't see us jumping on this right away, so moving to vNext and marking as up for grabs

@yishaigalatzer yishaigalatzer added this to the Client-VNext milestone Jan 26, 2016

@StevenLiekens

This comment has been minimized.

Show comment
Hide comment
@StevenLiekens

StevenLiekens Feb 7, 2016

I edited my post to make the important bits stand out more. If nobody wants to grab this then I'll have a go at it when time permits it.

StevenLiekens commented Feb 7, 2016

I edited my post to make the important bits stand out more. If nobody wants to grab this then I'll have a go at it when time permits it.

@toddm

This comment has been minimized.

Show comment
Hide comment

toddm commented Apr 29, 2016

@toddm toddm closed this Apr 29, 2016

@zhili1208 zhili1208 added this to the 3.5 Beta2 milestone Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment