Localize strings in NuGet.Core.sln #2041

Closed
emgarten opened this Issue Feb 2, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@emgarten
Contributor

emgarten commented Feb 2, 2016

Strings in the code ported from DNU in NuGet.Core.sln need to be localized.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Feb 14, 2017

Contributor

@rrelyea should this go in 4.0.1?

Contributor

emgarten commented Feb 14, 2017

@rrelyea should this go in 4.0.1?

@mishra14

This comment has been minimized.

Show comment
Hide comment
@mishra14

mishra14 Feb 14, 2017

Contributor

@emgarten : can you please update the issue with the list of these strings?

Contributor

mishra14 commented Feb 14, 2017

@emgarten : can you please update the issue with the list of these strings?

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Feb 14, 2017

Contributor

@mishra14 doing a find across the solution for all uses of ILogger would be a great way to get started on this 🍰

Contributor

emgarten commented Feb 14, 2017

@mishra14 doing a find across the solution for all uses of ILogger would be a great way to get started on this 🍰

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Feb 17, 2017

Contributor

Please investigate customer impact.

Contributor

rrelyea commented Feb 17, 2017

Please investigate customer impact.

@mishra14

This comment has been minimized.

Show comment
Hide comment
@mishra14

mishra14 Feb 21, 2017

Contributor

Searched the core solution. The only non-localized strings seem to be debug logs. Closing this for now. We can reopen this if needed.

Contributor

mishra14 commented Feb 21, 2017

Searched the core solution. The only non-localized strings seem to be debug logs. Closing this for now. We can reopen this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment