New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide dependency options when using project.json #2486

Closed
yishaigalatzer opened this Issue Apr 7, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@yishaigalatzer

yishaigalatzer commented Apr 7, 2016

Install and Update options and uninstall options are not supported in project.json, we should hide them in these scenarios (xproj, csproj + project.json)

image

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Apr 19, 2016

Contributor

@rrelyea @yishaigalatzer

What should be the behavior here if the Package Manager is opened via the Solution?

Should we show the dependency options if there is atleast one project in the solution which is not the scenario stated above?

Contributor

rohit21agrawal commented Apr 19, 2016

@rrelyea @yishaigalatzer

What should be the behavior here if the Package Manager is opened via the Solution?

Should we show the dependency options if there is atleast one project in the solution which is not the scenario stated above?

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Apr 19, 2016

Lets discuss with @harikm86 it probably needs a string of some kind telling the user that this doesn't impact xproj

yishaigalatzer commented Apr 19, 2016

Lets discuss with @harikm86 it probably needs a string of some kind telling the user that this doesn't impact xproj

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
Contributor

rohit21agrawal commented Apr 25, 2016

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon Apr 25, 2016

Sorry, was pretty late to the party. Have we decided how to handle this case when we do this from the Manage Packages in Solution command? Or are we going to track this separately in a different issue?

harikmenon commented Apr 25, 2016

Sorry, was pretty late to the party. Have we decided how to handle this case when we do this from the Manage Packages in Solution command? Or are we going to track this separately in a different issue?

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Apr 25, 2016

Contributor

@harikm86 We should track it in a separate issue.

Contributor

rohit21agrawal commented Apr 25, 2016

@harikm86 We should track it in a separate issue.

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon Apr 25, 2016

Did you open one or do you want me to?

harikmenon commented Apr 25, 2016

Did you open one or do you want me to?

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Apr 25, 2016

Contributor

@harikm86 you can open one and add in the details of the string we should display to indicate that those options are not valid for project.json scenarios.

Contributor

rohit21agrawal commented Apr 25, 2016

@harikm86 you can open one and add in the details of the string we should display to indicate that those options are not valid for project.json scenarios.

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon Apr 26, 2016

Thanks. I will take this offline with you and Rob and open an issue once I have a solid understanding of the scenario

harikmenon commented Apr 26, 2016

Thanks. I will take this offline with you and Rob and open an issue once I have a solid understanding of the scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment