New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the UI to search a V2 source, FindPackagesById is called twice for each ID #2517

Closed
joelverhagen opened this Issue Apr 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@joelverhagen
Member

joelverhagen commented Apr 9, 2016

Steps:

  1. Open 3.4.0+ VS package management UI on a project (or solution, doesn't matter).
  2. Select a V2 source.
  3. Open Fiddler (with HTTPS decrypted, given that the V2 source is HTTPS).
  4. Make some search, e.g. TorSharp.
  5. Click on a result in the search result list.

You will notice individual calls made to FindPackageById. One made during search, and one made when you clicked the package.

The root of the problem is that we make the first call to get the version list of a package and the second call to get all of the metadata for each version. We can save the results in memory from the first call so the second call is not necessary.

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen
Member

joelverhagen commented Apr 13, 2016

Closed with NuGet/NuGet.Client#484.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea May 10, 2016

Contributor

Verified fixed with 3.5.0-beta (build 3.5.0.1249)

Contributor

rrelyea commented May 10, 2016

Verified fixed with 3.5.0-beta (build 3.5.0.1249)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment