New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive allocations in version comparsion code #2632

Closed
pakrym opened this Issue Apr 21, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@pakrym

pakrym commented Apr 21, 2016

  1. HashCodeCombiner is class so it gets allocated a lot
  2. SemanticVersion operators create VersionComparer for each call
  3. SemanticVersion.IsPrerelease allocates IEnumerator while underlying type of _releaseLabels is array.
@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Apr 21, 2016

Member

Seems reasonable, but where was this perf problem apparent? What scenario I mean.

Member

joelverhagen commented Apr 21, 2016

Seems reasonable, but where was this perf problem apparent? What scenario I mean.

@pakrym

This comment has been minimized.

Show comment
Hide comment
@pakrym

pakrym Apr 21, 2016

Resolving libraries in dotnet build. Around ~30 mb allocations in total from version comparsion.

pakrym commented Apr 21, 2016

Resolving libraries in dotnet build. Around ~30 mb allocations in total from version comparsion.

@yishaigalatzer yishaigalatzer added this to the 3.5 RC milestone Apr 21, 2016

@pakrym pakrym closed this Apr 21, 2016

@zhili1208 zhili1208 modified the milestones: 3.5 Beta2, 3.6 Beta Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment