New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package manager should make it clear that options list in packages detail does not apply to project.json #2665

Closed
harikmenon opened this Issue Apr 27, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@harikmenon

harikmenon commented Apr 27, 2016

This is to track the continuation of work for #2486 (comment).

In this scenario, we should have a warning error message in the options section.

Icon: Information
Text: These options are not applicable to projects managing their dependencies through project.json.

Send me a mail offline if you need the warning icon.

@harikmenon harikmenon added this to the 3.5 Beta milestone Apr 27, 2016

@rrelyea rrelyea modified the milestones: 3.5 RC, 3.5 Beta Apr 27, 2016

@rrelyea rrelyea added the Type:Bug label Jun 7, 2016

@mishra14

This comment has been minimized.

Show comment
Hide comment
@mishra14

mishra14 Jul 1, 2016

Contributor

@harikmenon @rrelyea @yishaigalatzer @rohit21agrawal

Please let me know if this looks fine?

  1. WPF project launch - hence no warning.

project_json warning - project launch

2/3. Solutionj launch - hence warning.

project_json warning - solution launch 1
project_json warning - solution launch 2

Contributor

mishra14 commented Jul 1, 2016

@harikmenon @rrelyea @yishaigalatzer @rohit21agrawal

Please let me know if this looks fine?

  1. WPF project launch - hence no warning.

project_json warning - project launch

2/3. Solutionj launch - hence warning.

project_json warning - solution launch 1
project_json warning - solution launch 2

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon Jul 2, 2016

Looks good to me.

harikmenon commented Jul 2, 2016

Looks good to me.

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jul 5, 2016

Contributor

Screenshots look good..will wait for pull request before signing off!

Contributor

rohit21agrawal commented Jul 5, 2016

Screenshots look good..will wait for pull request before signing off!

@mishra14

This comment has been minimized.

Show comment
Hide comment
@mishra14

mishra14 Jul 6, 2016

Contributor

@harikmenon @rrelyea @yishaigalatzer

Had a PR/discussion with @rohit21agrawal . Based on that, I have changed the position of the warning to make it clearer.

Please let me know if this looks fine?

  • Solution launch with project.json and project.config projects - hence warning -

project_json warning - solution launch with warning

  • Solution launch with only project.json projects - no warning -

project_json warning - solution launch without warning

  • WPF/non project.json project launch - no warning

project_json warning - project config project launch

  • UWP/project.json project launch - no warning

project_json warning - project json project launch

Contributor

mishra14 commented Jul 6, 2016

@harikmenon @rrelyea @yishaigalatzer

Had a PR/discussion with @rohit21agrawal . Based on that, I have changed the position of the warning to make it clearer.

Please let me know if this looks fine?

  • Solution launch with project.json and project.config projects - hence warning -

project_json warning - solution launch with warning

  • Solution launch with only project.json projects - no warning -

project_json warning - solution launch without warning

  • WPF/non project.json project launch - no warning

project_json warning - project config project launch

  • UWP/project.json project launch - no warning

project_json warning - project json project launch

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jul 6, 2016

Contributor

I feel the warning icon should be aligned on the left with Install and Update options title

Contributor

rohit21agrawal commented Jul 6, 2016

I feel the warning icon should be aligned on the left with Install and Update options title

@mishra14

This comment has been minimized.

Show comment
Hide comment
@mishra14
Contributor

mishra14 commented Jul 6, 2016

@mishra14 mishra14 closed this Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment