New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label the unlabeled UIElements in Package Manager UI for accessibility #2745

Closed
harikmenon opened this Issue May 9, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@harikmenon

harikmenon commented May 9, 2016

[From Saqib Shaikh]
There are two classes of low-hanging fruit: unlabelled buttons and inconsistent keyboard focus.

The unlabelled buttons should be straight forward to fix – we just need to set the AutomationElement.Name property, or override ToString() on the backing class.

In terms of keyboard focus, we need to make sure that you can tab and shift+tab to everything that is actionable. However, you shouldn’t be able to tab to a label, for example. Furthermore, you should be able to tab to a container (like a list) but not to individual items. I think there’s also some inconsistency in terms of how long it takes for the feed to load, so would need to figure out this scenario.

@harikmenon harikmenon added the Type:Bug label May 9, 2016

@harikmenon harikmenon added this to the 3.5 RC milestone May 9, 2016

@rrelyea rrelyea modified the milestones: 3.4.5, 3.5 RC May 9, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea May 9, 2016

Contributor

We'll target fixing the accessibility names for 3.4.5. The tabbing issue may not fix in this release.

Contributor

rrelyea commented May 9, 2016

We'll target fixing the accessibility names for 3.4.5. The tabbing issue may not fix in this release.

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jun 3, 2016

Contributor

let's discuss relative priorities. would love to see this catch the 3.4.5 release, but depends on your other work, etc...

Contributor

rrelyea commented Jun 3, 2016

let's discuss relative priorities. would love to see this catch the 3.4.5 release, but depends on your other work, etc...

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jul 12, 2016

Contributor

We have made some improvements in this space for the 3.5 release already - specifically, all the unlabeled UI in the Package manager window is now labeled.
Going to keep this issue open, as we will continue to invest in this area in the future releases as well.

Contributor

rohit21agrawal commented Jul 12, 2016

We have made some improvements in this space for the 3.5 release already - specifically, all the unlabeled UI in the Package manager window is now labeled.
Going to keep this issue open, as we will continue to invest in this area in the future releases as well.

@rohit21agrawal rohit21agrawal changed the title from Fix accessibility issues in NuGet Client to Label the unlabeled UIElements in Package Manager UI for accessibility Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment