New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcoreapp11 and netstandard17 support #2998

Closed
weshaggard opened this Issue Jun 17, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@weshaggard

weshaggard commented Jun 17, 2016

cc @ericstj

In preparation for vNext we need to add netcoreapp11 and netstandard17 TFM support to nuget client

netcoreapp11 should map to netstandard17

we should also remap net463 to netstandard17 instead of its current netstandard16

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Jun 21, 2016

Wouldn't remapping net463 will be a breaking change. Why is that ok?

yishaigalatzer commented Jun 21, 2016

Wouldn't remapping net463 will be a breaking change. Why is that ok?

@weshaggard

This comment has been minimized.

Show comment
Hide comment
@weshaggard

weshaggard Jun 21, 2016

net463 has not yet shipped so it is currently in a floating state until that happens.

weshaggard commented Jun 21, 2016

net463 has not yet shipped so it is currently in a floating state until that happens.

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Jun 21, 2016

This still means requiring a min version of NuGet and reshipping of 2.12.

@rrelyea can we pull this into 3.5RTM?

yishaigalatzer commented Jun 21, 2016

This still means requiring a min version of NuGet and reshipping of 2.12.

@rrelyea can we pull this into 3.5RTM?

@weshaggard

This comment has been minimized.

Show comment
Hide comment
@weshaggard

weshaggard Jun 21, 2016

As you know this is always a problem and I would much prefer a solution that didn't require nuget client changes. Have there been any further thoughts on how we can feed this configuration into the client as opposed to hard-coding it in there?

weshaggard commented Jun 21, 2016

As you know this is always a problem and I would much prefer a solution that didn't require nuget client changes. Have there been any further thoughts on how we can feed this configuration into the client as opposed to hard-coding it in there?

@yishaigalatzer

This comment has been minimized.

Show comment
Hide comment
@yishaigalatzer

yishaigalatzer Jun 21, 2016

We haven't made progress in this area, and it is below the watermark compared to things we have to deliver to dev15. Regardless the issue of flipping the mapping is something that should be changed very carefully.

A very simple approach would be to make the framework mapping owned by your team, and we can take dependency on it, but it still doesn't solve in place updates without shipping a new version of NuGet.exe

yishaigalatzer commented Jun 21, 2016

We haven't made progress in this area, and it is below the watermark compared to things we have to deliver to dev15. Regardless the issue of flipping the mapping is something that should be changed very carefully.

A very simple approach would be to make the framework mapping owned by your team, and we can take dependency on it, but it still doesn't solve in place updates without shipping a new version of NuGet.exe

@joelverhagen

This comment has been minimized.

Show comment
Hide comment
@joelverhagen

joelverhagen Jun 28, 2016

Member

This still means requiring a min version of NuGet and reshipping of 2.12.

@yishaigalatzer, by this you mean having the corefx packages stamped with min client version matching the release this change coincides with, correct? As it looks today, that would be min client version of 2.13 as 2.12 has already shipped without this change.

Member

joelverhagen commented Jun 28, 2016

This still means requiring a min version of NuGet and reshipping of 2.12.

@yishaigalatzer, by this you mean having the corefx packages stamped with min client version matching the release this change coincides with, correct? As it looks today, that would be min client version of 2.13 as 2.12 has already shipped without this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment