New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimizedZipPackage cache leaves empty folders #3029

Closed
emgarten opened this Issue Jun 23, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@emgarten
Collaborator

emgarten commented Jun 23, 2016

NuGet.Core creates a new guid folder under NuGetScratch for each session of Visual Studio or nuget.exe when local packages are used. Upon closing the sub folders are cleaned up, but not the root. Each session appears to add a new empty guid folder.

Steps

  1. Open %temp%/NuGetScratch in file explorer
  2. Create a new project in Visual Studio 2013
  3. Install-package nuget.versioning
  4. Observe that %temp%/NuGetScratch now contains a guid folder with files
  5. Close Visual Studio

Expected
The guid folder should be deleted

Actual
The guid folder is now empty, but still exists

Clean up code is here, if packages exist the top block of code is hit. If no operations were performed the folder is deleted fully.
https://github.com/NuGet/NuGet2/blob/2.12/src/Core/Packages/OptimizedZipPackage.cs#L314-L334

@rohit21agrawal rohit21agrawal added this to the 2.13 milestone Jun 24, 2016

@rohit21agrawal

This comment has been minimized.

Show comment
Hide comment
@rohit21agrawal

rohit21agrawal Jun 24, 2016

Contributor

This will be a continuation of the work done in NuGet/NuGet2#33

Contributor

rohit21agrawal commented Jun 24, 2016

This will be a continuation of the work done in NuGet/NuGet2#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment